Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icicles: 2018-07-02 -> 2018-12-22 #52676

Closed
wants to merge 1 commit into from
Closed

icicles: 2018-07-02 -> 2018-12-22 #52676

wants to merge 1 commit into from

Conversation

scolobb
Copy link
Contributor

@scolobb scolobb commented Dec 22, 2018

Motivation for this change

Update the hashes of the files in Icicles.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

I merged this as bde995c because another hash had changed in the meantime.

@alyssais alyssais closed this Feb 22, 2019
alyssais added a commit that referenced this pull request Feb 22, 2019
@scolobb @alyssais
icicles: 2018-07-02 -> 2019-02-22
bde995c 
Closes #52676.

Co-authored-by: Alyssa Ross <hi@alyssa.is>
@scolobb
Copy link
Contributor Author

scolobb commented Feb 22, 2019

Thanks @alyssais !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scolobb @alyssais @GrahamcOfBorg