-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenopotential to degree and order 50 #2032
Conversation
The slow build is because of slow tests, specifically:
Maybe we should not use a geopotential tolerance of 0 for those... |
With the new geopotential tolerances, the tests take as long as they used to, but the build still takes more than 30 min; we can't merge this as-is. |
5a809e8
to
25e06f3
Compare
25e06f3
to
67aa345
Compare
For future reference: the detemplatization of |
geopotential { | ||
row { | ||
degree: 2 | ||
column {order: 0, cos: -9.0884339347424299e-05, sin: 0.0000000000000000e+00}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use 0
for the zeroes, like we did for the Earth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
numerics/max_abs_normalized_associated_legendre_functions_test.cc
Outdated
Show resolved
Hide resolved
Benchmarking: the loss of the |
Bump
max_geopotential_degree
and extend the numerical tables accordingly.