Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: 2.7.1 -> 3.0.0 #53022

Merged
merged 1 commit into from Dec 29, 2018
Merged

fish: 2.7.1 -> 3.0.0 #53022

merged 1 commit into from Dec 29, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Dec 28, 2018

Motivation for this change

New major version \o/.
See release notes: https://github.com/fish-shell/fish-shell/releases/tag/3.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ocharles @etu @rnhmjoj

@gebner
Copy link
Member

gebner commented Dec 29, 2018

LGTM. I just tried it in a VM and my configuration still works.

@adisbladis adisbladis merged commit b783cc7 into NixOS:master Dec 29, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Dec 29, 2018

Should we add --disable-internal-wcwidth?

@gebner gebner mentioned this pull request Dec 30, 2018
10 tasks
@gebner
Copy link
Member

gebner commented Dec 30, 2018

@jtojnar See #53069.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants