Rebased to master.

@volth have you been able to test this ?

It's been running on my home setup for a year or so without any hitch on my side.

@netixx are you able to address the above comments and continue with this PR?

Yes, sorry for the delay, the PR has been pending for a while and I was not monitoring it.

I also rebased to the current master to fix the conflicts. Let me know if it still needs modifying!

Does anyone know who we need to call in for review here?

I don't have time to properly review and test it, since I'm not using it anymore, but changes seem ok.

I don't know the policy about 'not so often' used configuration like this, so I let the more experienced people decide, but, if this request is merged, then it would be nice if this one was too: #53032 (since the existing openvswitch version is really old now).

Bumping up a level to @disassembler or @lheckemann 🤷‍♂️

Maybe @teto can have a look.

I use neither networkd or ovs (just need it when running mininet but I don't actually test the SDN capabilities). I can see some breaking changes. Considering the few people using the module that may be fine.
@netixx would you mind adding yourself as the maintainer of the module. You changes complexify it so we need someone to potentially deal wit the aftermath :p

Yes no problem. I just rebased and added myself as maintainer of the openvswitch nixos module.

@netixx Since there seems nobody else to test this, could you give me an example configuration?

The following example creates a vswitch named vswitch with one internal (= system) interface named test, with vlan 100 encapsulation (like SVI 100 in a switch, with eth0 configured as trunk).

The test interface can then be used as a regular interface in the system (works with systemd configuration mode, since scripted has problems on its own).

networking.vswitches = {
  vswitch = {
    interfaces = [
      {
        name="eth0";
      }
      {
        name="test";
        vlan=100;
        type="internal";
      }
    ];
  };
};

I this something that could help you ?

Any plans on getting this into unstable/master?

I rebased/fix conflicts with master branch.

Any hope of getting this merged ?

Tested using the following snippet:

  networking.vswitches.vswitch.interfaces = {
     wlan0 = {};
     test = {
       vlan=100;
       type="internal";
     };
  };

The idea was to comply with the name of the component http://www.openvswitch.org//support/dist-docs/ovs-vswitchd.8.pdf and make it clear the processed belong to OVS.