Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betaflight-configurator: init at 10.5.1 #53013

Merged
merged 4 commits into from Jun 5, 2019
Merged

betaflight-configurator: init at 10.5.1 #53013

merged 4 commits into from Jun 5, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Dec 28, 2018

Motivation for this change

Adding more GCS/Drone Configuration tools to the nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wucke13 wucke13 force-pushed the betaflight-configurator-naive branch from 1b835e0 to 68469e5 Compare February 6, 2019 15:07
@corngood
Copy link
Contributor

@ryantm @wucke13 I don't think this is WIP any more, is it?

@wucke13
Copy link
Contributor Author

wucke13 commented Apr 14, 2019

It is, but I'm on it right now. If you agree on writing the runner script using some shell magic instead of writeShellScriptBin, than I will adjust accordingly in the next hours

@corngood
Copy link
Contributor

Whatever works. I was just trying to ask some questions. I have no power here. :)

@wucke13 wucke13 force-pushed the betaflight-configurator-naive branch from 68469e5 to 4fe9cbb Compare April 14, 2019 17:04
@wucke13 wucke13 changed the title betaflight-configurator: init at 10.4.0 betaflight-configurator: init at 10.5.1 Apr 14, 2019
@wucke13
Copy link
Contributor Author

wucke13 commented Apr 14, 2019

@corngood Ready for merge. Not WIP anymore.

@wucke13 wucke13 force-pushed the betaflight-configurator-naive branch from 4fe9cbb to da95356 Compare April 18, 2019 07:28
@wucke13 wucke13 force-pushed the betaflight-configurator-naive branch from da95356 to 3d8162a Compare April 30, 2019 10:28
@nyanloutre
Copy link
Member

Hey, any news on this PR ?

@wucke13
Copy link
Contributor Author

wucke13 commented May 11, 2019

@nyanloutre I think its ready for merge

nyanloutre
nyanloutre reviewed May 30, 2019
View reviewed changes
Copy link
Member

@nyanloutre nyanloutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add this to make the export save feature work, else it would just crash when atempting to open the file explorer window

pkgs/applications/science/robotics/betaflight-configurator/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/robotics/betaflight-configurator/default.nix Outdated Show resolved Hide resolved
@wucke13 wucke13 force-pushed the betaflight-configurator-naive branch from 087541d to fd121cd Compare May 31, 2019 10:53
@wucke13
Copy link
Contributor Author

wucke13 commented May 31, 2019

@nyanloutre Thanks for the two commits too. I applied adjusted accordingly. Feel free to review the current state 😄

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/12

@matthewbauer matthewbauer merged commit 693a4ef into NixOS:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood corngood left review comments

@nyanloutre nyanloutre nyanloutre left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wucke13 @corngood @nyanloutre @nixos-discourse @ryantm @matthewbauer @GrahamcOfBorg