Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gvfs: Add TLS support #53016

Merged
merged 1 commit into from Dec 29, 2018
Merged

gnome3.gvfs: Add TLS support #53016

merged 1 commit into from Dec 29, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 28, 2018 •
edited

Motivation for this change

GLib Gio’s GFile uses gvfs daemon for opening files over HTTP protocol.
To support HTTPS, we need to include glib-networking.

Closes: #52963

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bjornfor

@jtojnar
gnome3.gvfs: Add TLS support
a90974a 
GLib Gio’s GFile uses gvfs daemon for opening files over HTTP protocol.
To support HTTPS, we need to include glib-networking.

Closes: NixOS#52963
worldofpeace
worldofpeace approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openclipart integration works in inkscape now 👍

I tested this in a gnome vm.

@worldofpeace
Copy link
Contributor

I think we should backport this one too.

@jtojnar jtojnar merged commit 484785c into NixOS:master Dec 29, 2018
@jtojnar jtojnar deleted the gvfs-tls branch December 29, 2018 12:16
@bjornfor
Copy link
Contributor

bjornfor commented Jan 1, 2019

Ah, this also fixes davs:// URLs in nautilus, which I would like to use with nextcloud. So +2 for backport. (I remember using davs:// before, in earlier NixOS releases, so I actually think this is a regression.)

@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 1, 2019

If someone wants to backport this and test this, feel free. I do not support GNOME 3 on stable though.

@bjornfor
Copy link
Contributor

bjornfor commented Jan 1, 2019

This commit doesn't apply cleanly on NixOS 18.09. So I'm not going to backport now :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @worldofpeace @bjornfor @GrahamcOfBorg