Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard-tools Add proper dependencies #53042

Merged
merged 1 commit into from Dec 29, 2018
Merged

wireguard-tools Add proper dependencies #53042

merged 1 commit into from Dec 29, 2018

Conversation

exi
Copy link
Contributor

@exi exi commented Dec 29, 2018 •
edited

wg-quick calls iproute, resolvconf and sysctl on Linux.
These dependencies where missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@exi
wireguard-tools Add proper dependencies
ca9e76e 
wg-quick calls iproute, resolvconf and sysctl on Linux.
These dependencies where missing.
@Ma27
Copy link
Member

Ma27 commented Dec 29, 2018

Confirmed locally and by checking sources.

@Ma27 Ma27 merged commit 693aee0 into NixOS:master Dec 29, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 29, 2018

@exi thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exi @Ma27 @GrahamcOfBorg