Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: 1.3.7 -> 1.3.8 #53018

Merged
merged 1 commit into from Dec 29, 2018
Merged

zstd: 1.3.7 -> 1.3.8 #53018

merged 1 commit into from Dec 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 28, 2018

Motivation for this change

https://github.com/facebook/zstd/releases/tag/v1.3.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@charles-dyfis-net charles-dyfis-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, and binaries execute, on darwin.

Using nix-review to build all dependencies, there's an indirect dependency with a failure which appears to be completely unrelated to this PR (python2.7-pyarrow cannot be tested when sandboxed in a manner that prevents binding to localhost; on the same environment, the issue reproduces with nix-build --check -A pkgs.python27Packages.pyarrow against master).

@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

Thanks for testing and report!

@dtzWill dtzWill merged commit 05e8f32 into NixOS:master Dec 29, 2018
@dtzWill dtzWill deleted the update/zstd-1.3.8 branch December 29, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants