Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Fix Mingw on 32-bit ARM #53029

Merged
merged 1 commit into from Jan 5, 2019
Merged

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Cannot use "gnu" abi but must use "gnueabi*". This just lets the ABI be
inferred. If/when we support MSVC, and that becomes the default ABI on
windows, we, will need to do this a different way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 29, 2018

I didn't even no that was a thing. Is this used for windows mobile or some windows phone stuff?

@Ericson2314
Copy link
Member Author

I didn't know either! Somebody on IRC needed help with this, and mentioned Windows CE, which probably would be the first version to support ARM.

@Ericson2314
Copy link
Member Author

@volth oh nice trick. That will work well.

@Ericson2314 Ericson2314 merged commit 1383670 into NixOS:master Jan 5, 2019
@Ericson2314 Ericson2314 deleted the windows-ce-arm branch January 5, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants