Change: show 'Max. Power' for vehicles rather than 'Power' #6997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for vehicles to change power, most likely due to checking railtype, also other vars in the consist.
This can be confusing for player in purchase / 'available trains' lists as the power value shown may not match the power value of the vehicle when built in a specific depot.
We handle other cases of variable properties by prefixing 'Max.', e.g. TE, speed, reliability etc.
I have done the same here as it seems by far the simplest solution, just a string change.
I rejected complicated solutions such as returning a range of power values to the cb in purchase list, or suppressing the display of the power value and replacing with extra buy menu text.
It's the responsibility of newgrf authors to return the correct value for max power to the purchase list.
Changed both purchase list and vehicle preview windows. Didn't change vehicle info window, as that should display actual current power IMHO.
Issue (with vehicle set to use lowest power in purchase list, as safest way to not ruin player's network)
Fix in context of purchase window (with vehicle set to use maximum power in purchase list)
Fix in context of preview window