obs-studio: apply fix for fdk-aac v2.0.0 #53008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
suggested changes
Jan 3, 2019
| patches = [ | ||
| (fetchpatch { | ||
| url = "https://patch-diff.githubusercontent.com/raw/obsproject/obs-studio/pull/1557.diff"; | ||
| sha256 = "0xq3sh1g8j58mpa4ryi9agqqpr41prrzagxmqafkbgfv6fjv3h0c"; |
There was a problem hiding this comment.
I'm guessing the patch has changed :
fixed-output derivation produced path '/nix/store/ij8k22jgavc1nzjvj4hy72av4iwlfswg-1557.diff' with sha256 hash '162fnkxh2wyn6wrrm1kzv7c2mn96kx35vlmk2qwn1nqlifbpsfyq' instead of the expected hash '0xq3sh1g8j58mpa4ryi9agqqpr41prrzagxmqafkbgfv6fjv3h0c'
There was a problem hiding this comment.
This is strange:
➜ nix-prefetch-url https://patch-diff.githubusercontent.com/raw/obsproject/obs-studio/pull/1557.diff
path is '/nix/store/raqc9k54zjgmxn7lwqmn0ycyhnjsr179-1557.diff'
0xq3sh1g8j58mpa4ryi9agqqpr41prrzagxmqafkbgfv6fjv3h0c
I think there might be some difference between how nix-prefetch-url and fetchpatch compute their hashes.
Answer is that fetchpatch is normalizing the patch (and change the resulting hash): https://github.com/NixOS/nixpkgs/blob/b27b443e145863b5b7f502d8beccb6767572f3c3/pkgs/build-support/fetchpatch/default.nix
vdemeester
added a commit
to vdemeester/home
that referenced
this pull request
Jan 4, 2019
… waiting for NixOS/nixpkgs#53008 to get merged. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Patch from pull request obsproject/obs-studio#1557
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)