Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argtable: init at 2.13 #53007

Closed
wants to merge 4 commits into from
Closed

argtable: init at 2.13 #53007

wants to merge 4 commits into from

Conversation

rsoeldner
Copy link

@rsoeldner rsoeldner commented Dec 28, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

delroth
delroth reviewed Dec 29, 2018
View reviewed changes
pkgs/tools/misc/argtable2/default.nix Outdated
version = "2.13";

src = fetchurl {
url = http://prdownloads.sourceforge.net/argtable/argtable2-13.tar.gz;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mirror://sourceforge/argtable/argtable2-13.tar.gz

nlewo
nlewo requested changes Jan 1, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this package in all-packages.nix.
Could you also squash your commits please?

nlewo
nlewo requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash your commits also?

pkgs/top-level/all-packages.nix
@@ -577,6 +577,8 @@ in

argtable = callPackage ../tools/misc/argtable {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to rename the existing argtable to argtable3 (both attribute and directory names).
And also define

argtable = argtable3;

It seems argtable3 (release 2017) is well maintained then argtable2 (release 2011) so we should encourage users to use argtable3. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 is it possible to change the argtable directory name - or are there other implications ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the attribute name is used by other derivations. So, you can change the directory path.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@AndersonTorres
Copy link
Member

The last upstream news:

https://sourceforge.net/p/argtable/news/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth left review comments

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rsoeldner @mmahut @AndersonTorres @delroth @nlewo @ryantm @joachifm @GrahamcOfBorg @Janik-Haag