Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] urn: 0.7.1 -> 0.7.2 #53015

Merged
merged 1 commit into from Dec 31, 2018
Merged

[18.09] urn: 0.7.1 -> 0.7.2 #53015

merged 1 commit into from Dec 31, 2018

Conversation

CrazedProgrammer
Copy link
Contributor

@CrazedProgrammer CrazedProgrammer commented Dec 28, 2018 •
edited

Motivation for this change

Backport update to version 0.7.2 (bugfix update).
Original PR: #53014

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build urn

@worldofpeace
Copy link
Contributor

@CrazedProgrammer You need to use git cherry-pick -xe.

https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

@CrazedProgrammer
urn: 0.7.1 -> 0.7.2
f3af4a6 
(cherry picked from commit cc25730)
Reason: Bugfix update.
@CrazedProgrammer
Copy link
Contributor Author

@worldofpeace Sorry about this, I won't make the same mistake again. Does this look good to you?

@worldofpeace
Copy link
Contributor

Sorry about this, I won't make the same mistake again.

Oh no it's fine. I don't believe in mistakes 😄

Does this look good to you?

Totally, going for the merge.

@worldofpeace worldofpeace merged commit 42f4123 into NixOS:release-18.09 Dec 31, 2018
@worldofpeace
Copy link
Contributor

@CrazedProgrammer Thanks 🎇

@CrazedProgrammer CrazedProgrammer deleted the urn-18.09 branch January 1, 2019 11:58
@CrazedProgrammer
Copy link
Contributor Author

CrazedProgrammer commented Jan 1, 2019 •
edited

Thank you! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrazedProgrammer @worldofpeace @GrahamcOfBorg