Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirsyncer: 0.17.0a3 -> 2018-08-05 #53040

Merged
merged 2 commits into from Dec 30, 2018
Merged

vdirsyncer: 0.17.0a3 -> 2018-08-05 #53040

merged 2 commits into from Dec 30, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Dec 29, 2018

Motivation for this change

Use the git version of vdirsyncer which works with the latest shippai version. See #52780.

cc @jgeerds @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner requested a review from FRidh as a code owner December 29, 2018 15:37
@worldofpeace
Copy link
Contributor

@gebner Can you squash 6d39308 and a84a80f?

Also correct the msg.

@gebner
Copy link
Member Author

gebner commented Dec 30, 2018

Done and thanks!

@gebner gebner merged commit a4e0985 into NixOS:master Dec 30, 2018
@gebner gebner mentioned this pull request Dec 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gebner @worldofpeace @GrahamcOfBorg @r-ryantm