Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: 4.25 -> 4.26 #53017

Merged
merged 2 commits into from Dec 29, 2018
Merged

strace: 4.25 -> 4.26 #53017

merged 2 commits into from Dec 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 28, 2018

Motivation for this change

https://github.com/strace/strace/releases/tag/v4.26

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
strace: change licenses
dfc35f1 
"The test suite is now provided under the terms of
the GNU General Public License version 2 or later."

"All the rest of strace is now provided under the terms of
the GNU Lesser General Public License version 2.1 or later."

> https://github.com/strace/strace/blob/27739ebccc96c0f70cd2aeb37fd7b0ecfef21724/NEWS#L4
worldofpeace
worldofpeace approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nix-review built and executed. All good 👍

I also addressed the license change.

@worldofpeace
Copy link
Contributor

Lets go for it.

@worldofpeace worldofpeace merged commit 94164f0 into NixOS:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @GrahamcOfBorg