Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quassel: 0.12.5 -> 0.13.0 #53049

Merged
merged 1 commit into from Dec 30, 2018
Merged

quassel: 0.12.5 -> 0.13.0 #53049

merged 1 commit into from Dec 30, 2018

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Dec 29, 2018 •
edited

Motivation for this change

0.13.0 came out a few weeks ago. @Phreedom @ttuegel does this look ok?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@Lucus16 This looks good, but this derivation needs a correction in general.
I have the fix, do you mind if I push it to your pr?

@Lucus16
Copy link
Contributor Author

Lucus16 commented Dec 30, 2018

I don't mind. I've temporarily given you access to my fork.

@worldofpeace
Copy link
Contributor

@Lucus16 I think if you've checked Allow edits from maintainers I'll be able to push since I'm a maintainer.

@Lucus16 @worldofpeace
quassel: 0.12.5 -> 0.13.0, cleanup
b89228b 
In particular we move the src into the actual quassel derivation
instead of using a `source.nix`.

Also use `fetchFromGitHub` since using `fetchurl` for github archives
is problematic.
@Lucus16
Copy link
Contributor Author

Lucus16 commented Dec 30, 2018

Ah, I didn't know that, cool.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build quassel quasselClient quasselDaemon

And now I'm just checking if it builds. I've already tested execution of quassel locally and it looked good.

Results for the build will be here https://github.com/NixOS/nixpkgs/pull/53049/checks

@Lucus16
Copy link
Contributor Author

Lucus16 commented Dec 30, 2018

I'm running quasselDaemon on my server and it runs fine.

@Lucus16
Copy link
Contributor Author

Lucus16 commented Dec 30, 2018

Tried quasselClient, that works fine too.

@worldofpeace
Copy link
Contributor

@Lucus16 great, I merge this in that case.

@worldofpeace worldofpeace merged commit 38f828e into NixOS:master Dec 30, 2018
@worldofpeace
Copy link
Contributor

@Lucus16 Thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lucus16 @worldofpeace @GrahamcOfBorg @Janik-Haag