hydra-eval-jobs: fix maintainer resolution #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago the data structure for maintainer descriptions in `nixpkgs` changed from a simple attr set with maintainer emails as values to an attribute set where the maintainer' nick is associated to an attribute set with email, GitHub handle and full name. Hydra can either parse a Nix list or fetches `shortName` from the associated attribute set (which is used for `meta.licenses` as each value in it contains a `shortName`). This behavior needs to be replicated for maintainers to retrieve the emails for `hydra-notify`. This change is backwards-compatible since `queryMetaStrings` is still able to understand lists, so old versions of `nixpkgs` or packages using the old maintainer data structure remain usable.
|
Thanks, verified it works :) https://hydra.nixos.org/build/90818518#tabs-details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago the data structure for maintainer descriptions in
nixpkgschanged from a simple attr set with maintainer emails asvalues to an attribute set where the maintainer' nick is associated to
an attribute set with email, GitHub handle and full name.
Hydra can either parse a Nix list or fetches
shortNamefrom theassociated attribute set (which is used for
meta.licensesas eachvalue in it contains a
shortName). This behavior needs to bereplicated for maintainers to retrieve the emails for
hydra-notify.This change is backwards-compatible since
queryMetaStringsis stillable to understand lists, so old versions of
nixpkgsor packages usingthe old maintainer data structure remain usable.