Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gap: 4r8p10 -> 4.10.0 #53037

Merged
merged 1 commit into from Dec 29, 2018
Merged

gap: 4r8p10 -> 4.10.0 #53037

merged 1 commit into from Dec 29, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 29, 2018

Motivation for this change

This new version also has a libgap replacement, so after the next sage
update gap-libgap-compatible and libgap won't be necessary anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Dec 29, 2018

@GrahamcOfBorg build gap gap-libgap-compatible libgap

@timokau
gap: 4r8p10 -> 4.10.0
1aea98e 
This new version also has a libgap replacement, so after the next sage
update gap-libgap-compatible and libgap won't be necessary anymore.
@timokau
Copy link
Member Author

timokau commented Dec 29, 2018

@GrahamcOfBorg build gap gap-libgap-compatible libgap

@timokau timokau merged commit 8cd7b5a into NixOS:master Dec 29, 2018
@timokau timokau deleted the gap-4.10.0 branch December 29, 2018 15:06
@collares collares mentioned this pull request Oct 12, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg