Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/boot: replace deprecated Raspberry Pi configuration option #55457

Merged
merged 1 commit into from Feb 8, 2019
Merged

nixos/boot: replace deprecated Raspberry Pi configuration option #55457

merged 1 commit into from Feb 8, 2019

Conversation

jslight90
Copy link
Contributor

Motivation for this change

According to the Raspberry Pi configuration documentation, using arm_control=0x200 has been deprecated in favor of using arm_64bit=1 to activate the 64-bit boot control bit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Built for patform(s)
    • AArch64 (Raspberry Pi 3B+)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit 9d416b3 into NixOS:master Feb 8, 2019
@jslight90 jslight90 mentioned this pull request Jul 30, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jslight90 @matthewbauer @GrahamcOfBorg