Fix: Remove desert around lakes upon generation. #7194
Conversation
|
So this is an extremely rare case I think? The code looks fine, but by the context I can see the prelude to each of the added blocks checks for "tile is not desert". So this would only apply to rivers ending in a lake right at the edge of a desert. |
There was a problem hiding this comment.
Looks correct, but with the constant 5 now being repeated four times in the code (after applying this patch), I think it would be appropriate to change it to a named constant. Maybe name it RIVER_OFFSET_DESERT_DISTANCE and put in water.h together with the declaration of RiverModifyDesertZone.
…h radius to create non-desert around a river tile.
SamuXarick
force-pushed
the
remove-desert-around-lakes
branch
from
87f145d
to
75f9ee3
Compare
|
I wonder if there is an easy way to trigger the issue this intends to fix... |
|
I hacked in a console command to force a river, and got it to make a lake in a tropical zone bordering a desert zone. This is the result in master without this patch:
This is with the patch, the marked tiles were desert before the river command:
|
No description provided.