New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg-full: nvenc doesn't imply nonfree licensing #55442
Conversation
In order to build ffmpeg with nvenv you have to bring in Even if the resulting built package is redistributable, it's still unfree. |
Not so fast, please reopen. |
From the official LICENSE notice from ffmpeg git tree :
|
"We are not certain" doesn't sound too convincing. I'd say the LICENSE file is obsolete, since they take care of all the nonfree stuff in the configure script and it allows to enable nvenc in a LGPL setting. |
"We require" is convincing enough, and I don't consider a git message or a forum post to be more official and "convincing". As a distro we can't disregard a licence notice, as I'm sure you understand. |
I'd propose closing this PR until it is more clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify licensing with upstream
Clarified. The LICENSE file has been fixed upstream. |
They were fast to react! Thanks for your effort to clarify. @jacereda would you care to also update |
Fixed the license field. |
It's a port of #55442 to master.
Eh, well, ported to master and 19.03, along with a couple other fixes. |
Woah I totally missed this was targeted at release-18.09 and not master.. |
Motivation for this change
Looks like this assertion was added when NVENC implied non-free.
After applying this change, you can check the generated executable is distributable with:
ffmpeg -L
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)