Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybase updates #55428

Merged
merged 3 commits into from Feb 8, 2019
Merged

Keybase updates #55428

merged 3 commits into from Feb 8, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Wanted to keep these up to date.

https://github.com/keybase/client/releases

cc @rvolosatovs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

I'm seeing that keybase-gui has gnome2.GConf as build input.

I'd like to figure out if that is needed, as I'd like to remove that dependency wherever possible.

@kalbasit
Copy link
Member

kalbasit commented Feb 8, 2019

@worldofpeace I'm checking on my side if that's removable.

@kalbasit
Copy link
Member

kalbasit commented Feb 8, 2019

@worldofpeace it worked well without it. It built correctly and the gui behaved just fine.

$ nix-shell -p nur.repos.kalbasit.nix-verify --run 'nix-verify -I nixpkgs=`pwd` -A keybase-gui

@worldofpeace
Copy link
Contributor Author

Removing this now then.

@worldofpeace worldofpeace merged commit ce8c243 into NixOS:master Feb 8, 2019
@worldofpeace worldofpeace deleted the keybase-updates branch February 8, 2019 03:35
@kalbasit kalbasit mentioned this pull request Feb 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @kalbasit @GrahamcOfBorg