Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gImageReader fixed missing Icons #55451

Closed
wants to merge 4 commits into from
Closed

gImageReader fixed missing Icons #55451

wants to merge 4 commits into from

Conversation

aakropotkin
Copy link
Contributor

Motivation for this change

Previous package forgot to properly install UI Icons.

Things done

The issue was fixed by adding gnome3.defaultIconTheme to buildInputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Feb 8, 2019

I believe this is the case for several packages. What if I use a different Gtk theme ? There might be some hook to add this automatically @jtojnar I think you are the gtk specialist ?!

@jtojnar
Copy link
Contributor

jtojnar commented Feb 8, 2019

This is currently not settled issue. On one hand, having adwaita-icon-theme in the expression will make the icons work even when the user has no icons installed; on the other hand, it will require people using different theme to have Adwaita in the closure. See also discussion in #43150

Also, if you choose the first option, defaultIconTheme is deprecated alias, you should use adwaita-icon-theme directly.

@aakropotkin
Copy link
Contributor Author

This is currently not settled issue. On one hand, having adwaita-icon-theme in the expression will make the icons work even when the user has no icons installed; on the other hand, it will require people using different theme to have Adwaita in the closure. See also discussion in #43150

Also, if you choose the first option, defaultIconTheme is deprecated alias, you should use adwaita-icon-theme directly.

Do you have a suggestion for a more holistic fix?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 13, 2019

Currently there are these two options and you need to choose based on your priorities.

@worldofpeace
Copy link
Contributor

Closing due to inactivity.

The solutions provided by jtojnar still stand though, but I feel in the future we're going to prefer having an icon theme just installed globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aakropotkin @teto @jtojnar @worldofpeace @GrahamcOfBorg