Codechange: making the style of MakeVoid calls uniform #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
requested changes
Feb 7, 2019
There was a problem hiding this comment.
Good in principle, though I'm not a fan of the const uint maxX/Y additions. No point making a constant that's only used in one place. Probably not worth it for the other places either - any half decent compiler will optimise them out (is the function itself marked inline?)
I'd recommend looking for other potential uses of TileXY as well, I have no doubt there are many others
Oh, and the commit should be Codechange: ... when no user visible changes are made
GabdaZM
changed the title
LordAro
approved these changes
Feb 8, 2019
| @@ -995,8 +995,8 @@ void GenerateTerrainPerlin() | |||
|
|
|||
| /* First make sure the tiles at the north border are void tiles if needed. */ | |||
| if (_settings_game.construction.freeform_edges) { | |||
| for (int y = 0; y < _height_map.size_y - 1; y++) MakeVoid(_height_map.size_x * y); | |||
| for (int x = 0; x < _height_map.size_x; x++) MakeVoid(x); | |||
There was a problem hiding this comment.
seems to me like _height_map could go away entirely, but that's for another time :)
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started form making
sizex * y + xintoTileXY(x, y).