hunspell-dicts: add support for Hungarian dictionary #55412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibreOffice has a comprehensive collection of Hunspell dictionaries. `mkDictFromLibreOffice` helper is introduced to make it easy to add new dictionaries from this repository. `license` is parametrized because each dictionary has its own license.
vlaci
commented
Feb 7, 2019
| , sourceRoot ? dictFileName }: | ||
| mkDict rec { | ||
| name = "hunspell-dict-${shortName}-libreoffice-${version}"; | ||
| version = "6.2.0.3"; |
There was a problem hiding this comment.
I am a bit tentative on using LibreOffice's version here. It is certainly simpler to keep track source updates this way but it doesn't communicate the upstream version number of the dictionary (1.7 for Hungarian in this case)
|
Thanks! I think we could get most dictionaries from libreoffice. I assume they are better maintained then our current one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
LibreOffice has a comprehensive collection of Hunspell dictionaries.
mkDictFromLibreOfficehelper is introduced to make it easy to add newdictionaries from this repository.
licenseis parametrized becauseeach dictionary has its own license.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)