pkgs/misc/cups/drivers: add brother mfcl3770cdw #55531
Conversation
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
from
15bac4a
to
7cabd6b
Compare
|
Hi! Quick question / heads-up, depending: does your printer driver hard-code some settings, e.g. page size to A4? See #53027 and a discourse post. My Brother printer's driver, and a couple other user's is seemingly disregarding the settings set in the print. As far as I was concerned, this was hard to spot until I realized what was going on. Thanks. (Additionally, looks like there's a merge conflict.) |
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
3 times, most recently
from
65e9569
to
b077355
Compare
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
from
b077355
to
c6017b4
Compare
|
@samueldr It seems to be the case here too. I have tried to print on portrait A5 (A4 split in half) and the result was as if the paper was A4. Are you suggesting to block this PR on that issue? |
|
@steveej since a bunch of the drivers in Nixpkgs already share the flaw I wouldn't block. Though it would be nice to get a taskforce (1) looking at and fixing the issue (2) making a brother driver helper/builder that handles the common formats; after all it seems that they are generally similar when close in age. |
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
from
c6017b4
to
05850af
Compare
|
@samueldr Alright, I will take a stab at it eventually. Can't be that bad to debug a CUPS issue 🙃 WRT this PR, CI should turn green now. |
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
4 times, most recently
from
46a7074
to
9e70c26
Compare
|
I believe this driver needs to follow the same form as Having said that, I see that the mentioned drivers set interpreter path in this way: So I believe that solving issue raised in #55531 (comment) is not required to merge this PR. I propose we do the simple refactoring and merge this. |
This adds the printer driver for the Brother MFCL3770CDW. It combines the cups-wrapper and the driver in one file which allows sharing common variables and making it less error-prone than the other Brother drivers in repository. I volunteer for maintaining this one as long as I've got the model around.
steveej
force-pushed
the
pr/cups-driver-mfcl3770cdw
branch
from
9e70c26
to
64b2dc8
Compare
While I'm aware that this PR takes a different approach I don't agree that it needs to follow the existing one. A further refactor could take this one as an example, or unify all of them to an even different one. |
|
@steveej In your approach you bind |
|
@veprbl Making driver overrideable is a good suggestion, thanks! I think it's not a difficult change to add here. The approach is motivated by trying to minimize redundancy between the driver and the wrapper. |
|
@samueldr please take a look at the changes I made recently, and see if your comments are addressed appropriately. |
I've been using the printer on my system and it works OK, besides the side-effects you've mentioned in #55531 (comment) already. It's not bad enough to really debug the issue though. |
|
@samueldr I don't have merge access, would you mind merging this as you've approved it? Or are you waiting for another maintainer to double-check? |
| unpackPhase = "dpkg-deb -x $src $out"; | ||
|
|
||
| installPhase = '' | ||
| basedir=${driver}/${reldir} |
There was a problem hiding this comment.
Here is a way to improve overridability:
inherit driver;
installPhase = ''
basedir="$driver/${reldir}"
This adds the printer driver for the Brother MFCL3770CDW.
It combines the cups-wrapper and the driver in one file which allows
sharing common variables and making it less error-prone than the other
Brother drivers in repository.
I volunteer for maintaining this one as long as I've got the model
around.
Motivation for this change
New driver for new hardware.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)