Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mumsi: Init at unstable-2018-12-12 #55532

Merged
merged 1 commit into from Jul 17, 2019
Merged

mumsi: Init at unstable-2018-12-12 #55532

merged 1 commit into from Jul 17, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Feb 10, 2019

Motivation for this change

I'd like to use Mumsi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Feb 17, 2019

This project is dead upstream, why would you want to put it in nixpkgs now?

@dasJ
Copy link
Member Author

dasJ commented Feb 17, 2019 •
edited

Completeness. Why wouldn't the package be in nixpkgs? Maybe somebody wants to use it as well and could just install it. Even though it's not developed actively, it still works and can be used (which you are aware of as you are currently running it on your NAS).

aanderse
aanderse requested changes Jul 13, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dasJ If there is no alternative software that covers the functionality then you're correct there should be no issue packaging this. I see there are forks too. Great.

As for the requested changes... this PR was filed some time ago so I know you know what to do 😄

pkgs/development/libraries/mumlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mumlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mumlib/default.nix Show resolved Hide resolved
@dasJ
Copy link
Member Author

dasJ commented Jul 14, 2019

@aanderse Fixed and rebased

@aanderse
Copy link
Member

@GrahamcOfBorg build mumlib mumsi

@aanderse aanderse changed the title mumsi: Init at git-2019-02-10 mumsi: Init at unstable-2018-12-12 Jul 16, 2019
aanderse
aanderse approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry about the delay on this. As always, thanks for your hard work @dasJ!

@aanderse aanderse merged commit e45406c into NixOS:master Jul 17, 2019
@dasJ dasJ deleted the mumsi branch July 17, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @ajs124 @aanderse @GrahamcOfBorg