Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.gita: init at 0.7.3 #55533

Merged
merged 1 commit into from Feb 11, 2019
Merged

gitAndTools.gita: init at 0.7.3 #55533

merged 1 commit into from Feb 11, 2019

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Feb 10, 2019

Motivation for this change

Gita is a tool for managing multiple repositories. It's helpful to me so I wanted to add it to the main repo. Please state if I did something weird because I am currently packaging bigger Python applications which kind of working so I'll fix myself before causing headache on PR step :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

Please use python3(Packages) as an argument and avoid using pythonPackages.callPackage.
Some more stuff needs to be changed but please give me until tomorrow to review this thoroughly.

@seqizz
Copy link
Contributor Author

seqizz commented Feb 11, 2019

All done

etu
etu previously requested changes Feb 11, 2019
View reviewed changes
pkgs/applications/version-management/gita/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/gita/default.nix Outdated Show resolved Hide resolved
@seqizz
Copy link
Contributor Author

seqizz commented Feb 11, 2019

I need to fix my IDE I guess, I am used to 4-spaces, should be ok now.

dotlambda
dotlambda requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building gita, I get

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or, if there are no tests, set doCheck = false and add a comment with the reason.

pkgs/applications/version-management/gita/default.nix Outdated
sha256 = "05sv16m73slldsy73x9s4l3q0md5zpxzg9x9hm2gg6h1dfi6q1r0";
};

pythonPath = with python3Packages; [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pythonPath = with python3Packages; [
propagatedBuildInputs = with python3Packages; [

pkgs/applications/version-management/gita/default.nix Outdated

meta = with lib; {
description = "A command-line tool to manage multiple git repos";
homepage = https://pypi.org/project/gita/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://pypi.org/project/gita/;
homepage = https://github.com/nosarthur/gita;

pkgs/top-level/all-packages.nix Outdated
@@ -697,6 +697,8 @@ in
optgamsFile = config.gams.optgamsFile or null;
};

gita = callPackage ../applications/version-management/gita {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved to gitAndTools, i.e. pkgs/applications/version-management/git-and-tools/default.nix, and the expression should be moved to pkgs/applications/version-management/git-and-tools/gita/default.nix.

@etu etu dismissed their stale review February 11, 2019 08:27

My notes was fixed, but I don't want to approve it as of now

@seqizz seqizz changed the title gita: init at 0.7.2 gita: init at 0.7.3 Feb 11, 2019
@seqizz
Copy link
Contributor Author

seqizz commented Feb 11, 2019

Thanks for the suggestions, all pushed.
Seems like released versions doesn't include tests and I didn't want to get a commit on git and define it as release myself.
Bumped to newest pypi release meanwhile.
And sorry for being pita :)

@dotlambda dotlambda changed the title gita: init at 0.7.3 gitAndTools.gita: init at 0.7.3 Feb 11, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build gitAndTools.gita

@dotlambda dotlambda merged commit 936c9f4 into NixOS:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@dotlambda dotlambda dotlambda requested changes

@etu etu etu left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seqizz @dotlambda @etu @symphorien @GrahamcOfBorg