Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdedup: 3.0.1 -> 3.1.1 #55530

Merged
merged 3 commits into from Feb 13, 2019
Merged

rdedup: 3.0.1 -> 3.1.1 #55530

merged 3 commits into from Feb 13, 2019

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Feb 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Feb 10, 2019

@GrahamcOfBorg build rdedup

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2019

@GrahamcOfBorg build rdedup

@steveej
Copy link
Contributor Author

steveej commented Feb 11, 2019

Thanks for jumping in @dywedir. The last build error is beyond the build system and needs fixing upstream. That is, if the author has an interest of making this work on Darwin.

@Mic92
Copy link
Member

Mic92 commented Feb 11, 2019 •
edited

We should mark it at least as broken for macOS in this case.

@steveej
Copy link
Contributor Author

steveej commented Feb 13, 2019

@Mic92

We should mark it at least as broken for macOS in this case.

Done.

@dywedir
Copy link
Member

dywedir commented Feb 13, 2019

Thanks!

@dywedir dywedir merged commit 8f1ab5f into NixOS:master Feb 13, 2019
@steveej steveej deleted the pr/bump-rdedup-3.1.1 branch February 13, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steveej @dywedir @Mic92 @GrahamcOfBorg