Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lguf-brightness: Init at 2018-02-07 #55406

Merged
merged 1 commit into from Feb 8, 2019
Merged

lguf-brightness: Init at 2018-02-07 #55406

merged 1 commit into from Feb 8, 2019

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Feb 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu
etu requested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of improvement suggestions provided.

We should also specify the license of this project in the meta.

And they don't have a license file, but it says in the comments of this source file that it's LGPL 2.1 or newer: https://github.com/periklis/lguf-brightness/blob/master/main.cpp

pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
pkgs/misc/lguf-brightness/default.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor

etu commented Feb 8, 2019

@periklis Good work, we'd appreciate if the version number in the commit message was updated as well :-)

@etu
Copy link
Contributor

etu commented Feb 8, 2019

@GrahamcOfBorg build lguf-brightness

@etu
Copy link
Contributor

etu commented Feb 8, 2019

@GrahamcOfBorg eval

@etu etu changed the title lguf-brightness: Init at d194272b lguf-brightness: Init at 2018-02-07 Feb 8, 2019
@etu
Copy link
Contributor

etu commented Feb 8, 2019

@GrahamcOfBorg build lguf-brightness

@etu
Copy link
Contributor

etu commented Feb 8, 2019

@periklis When I try executing this binary, I only get a new prompt and the status returned from last executed command is 255. Is this the expected behavior when not having that fancy piece of monitor as it's supposed to be used with?

I would believe that it is but it's not saying that much if I append either --help or --version either, it just returns 255 as status.

@periklis
Copy link
Contributor Author

periklis commented Feb 8, 2019 •
edited

@etu this tool is currently working only if libusb detects an LG UltraFine monitor and has very rudimentary error messages.

@etu etu merged commit ffc604e into NixOS:master Feb 8, 2019
@etu
Copy link
Contributor

etu commented Feb 8, 2019

@periklis Ok, thank you 🙂

Just wanted to confirm that.

@periklis periklis deleted the lguf-brightness branch February 8, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @etu @GrahamcOfBorg