Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] php72: 7.2.13 -> 7.2.15 #55402

Merged
merged 2 commits into from Feb 8, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Feb 7, 2019

Motivation for this change

Changelog: http://php.net/ChangeLog-7.php#7.1.26
(cherry picked from commit 49538f6)

Backport of #55399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu changed the title php71: 7.1.25 -> 7.1.26 [18.09 backport] php71: 7.1.25 -> 7.1.26 Feb 7, 2019
@etu etu added 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. labels Feb 7, 2019
@globin
Copy link
Member

globin commented Feb 8, 2019

From the branch name you wanted this to be the backport of the 7.2 update

7.1 backported in #55400

@etu
Copy link
Contributor Author

etu commented Feb 8, 2019

Good point, I think I cherry-picked the wrong hash... I'll push this soon.

@etu etu reopened this Feb 8, 2019
@etu
Copy link
Contributor Author

etu commented Feb 8, 2019

@globin There, I fixed it :-)

@etu etu changed the title [18.09 backport] php71: 7.1.25 -> 7.1.26 [18.09 backport] php72: 7.2.13 -> 7.2.15 Feb 8, 2019
@globin globin merged commit e50e323 into NixOS:release-18.09 Feb 8, 2019
@etu etu deleted the php72-update-stable branch February 8, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants