Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hetzner-kube: 0.3.1 -> 0.3.2rc1 #55403

Merged
merged 2 commits into from Mar 9, 2019
Merged

hetzner-kube: 0.3.1 -> 0.3.2rc1 #55403

merged 2 commits into from Mar 9, 2019

Conversation

offlinehacker
Copy link
Contributor

hetzner-kube: 0.3.1 -> 0.3.2rc1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker changed the title ###### Motivation for this change hetzner-kube: 0.3.1 -> 0.3.2rc1 Feb 7, 2019
@worldofpeace
Copy link
Contributor

Why a release candidate?

@offlinehacker
Copy link
Contributor Author

Well their versioning is a bit weird: https://github.com/xetys/hetzner-kube/releases

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 19, 2019 •
edited

Well their versioning is a bit weird: https://github.com/xetys/hetzner-kube/releases

Indeed that is kinda weird. Especially their use of RC, and certain releases being pre-releases.
I can see you went with the one labeled Latest Release but I don't get why 4.x.x.* wouldn't be a stable release.

Perhaps open an issue?

@offlinehacker
Copy link
Contributor Author

@GrahamcOfBorg build hetzner-kube

@offlinehacker
Copy link
Contributor Author

@worldofpeace yeah agreed, i opened issue: xetys/hetzner-kube#252

Currently i'm not using hetzner-kube, so i can't really say what is working in what version.

@worldofpeace worldofpeace merged commit cec337d into NixOS:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @worldofpeace @GrahamcOfBorg