Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09 backport] php71: 7.1.25 -> 7.1.26 #55400

Merged
merged 1 commit into from Feb 8, 2019
Merged

[18.09 backport] php71: 7.1.25 -> 7.1.26 #55400

merged 1 commit into from Feb 8, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Feb 7, 2019

Motivation for this change

Changelog: http://php.net/ChangeLog-7.php#7.1.26
(cherry picked from commit 49538f6)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu added 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. labels Feb 7, 2019
@globin globin merged commit 8618619 into NixOS:release-18.09 Feb 8, 2019
@globin globin mentioned this pull request Feb 8, 2019
Merged
10 tasks
@etu etu deleted the php71-update-stable branch February 8, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @globin @GrahamcOfBorg