nixos/manual: warn on missing xml:id #55396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Feb 7, 2019
| @@ -265,6 +265,7 @@ in rec { | |||
| xsltproc \ | |||
| ${manualXsltprocOptions} \ | |||
| --stringparam target.database.document "${olinkDB}/olinkdb.xml" \ | |||
| --stringparam id.warnings "1" \ | |||
There was a problem hiding this comment.
You're my hero for this. Maybe better to extend this list:
nixpkgs/nixos/doc/manual/default.nix
Line 132 in 4c0230e
There was a problem hiding this comment.
Well, this seems to only impact HTML documents. But adding it to the global options may be better if someone only tests it with some other version without generating the HTML. Not too sure really. What do you think ?
|
Make sense. Let’s do it as is.
…Sent from my iPhone
On Feb 7, 2019, at 10:43, Guillaume Maudoux ***@***.***> wrote:
@layus commented on this pull request.
In nixos/doc/manual/default.nix:
> @@ -265,6 +265,7 @@ in rec {
xsltproc \
${manualXsltprocOptions} \
--stringparam target.database.document "${olinkDB}/olinkdb.xml" \
+ --stringparam id.warnings "1" \
Well, this seems to only impact HTML documents. But adding it to the global options may be better if someone only tests it with some other version without generating the HTML. Not too sure really. What do you think ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
matthewbauer
approved these changes
Feb 7, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep the manual reproducible, we need to avoid randomly
generated ids. This patch enables warning on missing ids.
A further step could turn them to errors, but the case of
partintroblocks needs to be solved first.
See #55375