[Gecko Bug 1519347] Fix filtering jsshell tests #15314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach based on filtering the JSON data directly has a number of problems that need more work to resolve, and the upstream change to cache the manifest between update and usage has made these problems blockers. In order to get things updated again, use the construted ManifestItem objects as the basis for filtering. This is a deoptimistation since it requires constructing a bunch of objects, but it's at least working. Differential Revision: https://phabricator.services.mozilla.com/D18978 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1519347 gecko-commit: c983e907bbfdb768b3745b2ba6616469880e3a84 gecko-integration-branch: central gecko-reviewers: Ms2ger
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach based on filtering the JSON data directly has a
number of problems that need more work to resolve, and the upstream
change to cache the manifest between update and usage has made these
problems blockers. In order to get things updated again, use the
construted ManifestItem objects as the basis for filtering. This is a
deoptimistation since it requires constructing a bunch of objects, but
it's at least working.
Differential Revision: https://phabricator.services.mozilla.com/D18978
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1519347
gecko-commit: c983e907bbfdb768b3745b2ba6616469880e3a84
gecko-integration-branch: central
gecko-reviewers: Ms2ger