Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slirp4netns: init at v0.3.0-alpha.2 #55446

Merged
merged 1 commit into from Feb 14, 2019
Merged

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Feb 8, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


stdenv.mkDerivation rec {
name = "slirp4netns-${version}";
version = "0.3.0-alpha.2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of having two versions for this; one for v2 and v3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be easy to do, but I'd prefer to just merge this and upgrade to proper v3 whenever that's released.

@nlewo
Copy link
Member

nlewo commented Feb 11, 2019

Actually, I don't know what to do with this PR because it is still in alpha and nobody wants to maintain it:/
@samueldr @vcunat As release managers, what do you think?

@nlewo
Copy link
Member

nlewo commented Feb 11, 2019

But I really appreciate your sharing, which could be useful for others, including myself:)
@tilpner Are you playing with rootless containers?

@tilpner
Copy link
Member Author

tilpner commented Feb 11, 2019

I packaged the alpha version because the changelog said Fix CVE-2019-6778 (rootless-containers/slirp4netns#67), and I figured it might not be a problem to init a package to an alpha version, because nobody was already depending on it. It would be different if people were already using slirp4netns, but this can't break anything because nobody will upgrade to it.

Yes, I was using rootless podman for an experiment, but I no longer need it.

Edit: 0.2.1 fixes that vulnerability too, so that would be okay too

@vcunat
Copy link
Member

vcunat commented Feb 11, 2019

Hmm, I'm afraid I don't have a solution for this meta-question. Actually, I already have at least one nix expression for a package lying somewhere that seems to work OK but I ended up not using the package in the end and I haven't "published" the expression anywhere.

Advantages (of merging)
  • it shouldn't break anything
  • they would make it easier for people to try the package and start using it, as not everyone can just write such an expression within a couple minutes
Disadvantages (of merging)
  • it would probably just rot in nixpkgs
  • not much indication in nixpkgs how much a package is maintained

I don't know... it reminds me of our usage meta.broken a little, but that's different: an intermediate state for rotting/unmaintained packages between breakage and removal from nixpkgs.

@orivej
Copy link
Contributor

orivej commented Feb 11, 2019

I too have a private derivation of slirp4netns :) It looks like this + enableParallelBuilding = true;.
Please add me as the maintainer. I'm ok with 0.3.0-alpha.2.
I'd slightly prefer for it to be in tools/networking rather than in applications/virtualization.

@tilpner
Copy link
Member Author

tilpner commented Feb 13, 2019

Moved, parallel building enabled, @orivej added as maintainer. Merge when ready :)

@orivej
Copy link
Contributor

orivej commented Feb 14, 2019

Thank you!

@orivej-nixos orivej-nixos merged commit 9f93ed5 into NixOS:master Feb 14, 2019
@AkihiroSuda
Copy link

@orivej Could you open PR for adding NixOS pkg to slirp4netns README?
https://github.com/rootless-containers/slirp4netns/blob/master/README.md#install-from-binary

@orivej
Copy link
Contributor

orivej commented Feb 14, 2019

OK, but we should wait until it reaches the nixpkgs-unstable channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants