New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slirp4netns: init at v0.3.0-alpha.2 #55446
Conversation
|
||
stdenv.mkDerivation rec { | ||
name = "slirp4netns-${version}"; | ||
version = "0.3.0-alpha.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of having two versions for this; one for v2 and v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be easy to do, but I'd prefer to just merge this and upgrade to proper v3 whenever that's released.
But I really appreciate your sharing, which could be useful for others, including myself:) |
I packaged the alpha version because the changelog said Fix CVE-2019-6778 (rootless-containers/slirp4netns#67), and I figured it might not be a problem to init a package to an alpha version, because nobody was already depending on it. It would be different if people were already using slirp4netns, but this can't break anything because nobody will upgrade to it. Yes, I was using rootless podman for an experiment, but I no longer need it. Edit: 0.2.1 fixes that vulnerability too, so that would be okay too |
Hmm, I'm afraid I don't have a solution for this meta-question. Actually, I already have at least one nix expression for a package lying somewhere that seems to work OK but I ended up not using the package in the end and I haven't "published" the expression anywhere. Advantages (of merging)
Disadvantages (of merging)
I don't know... it reminds me of our usage |
I too have a private derivation of slirp4netns :) It looks like this + |
Moved, parallel building enabled, @orivej added as maintainer. Merge when ready :) |
Thank you! |
@orivej Could you open PR for adding NixOS pkg to slirp4netns README? |
OK, but we should wait until it reaches the nixpkgs-unstable channel. |
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)