Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for scroll snap #15318

Merged
merged 2 commits into from May 9, 2019

Conversation

hiikezoe
Copy link
Contributor

No description provided.

Hiroyuki Ikezoe added 2 commits February 10, 2019 19:26
Given that the test description is mentioning scrollBy, scrollBy should be used
there.
The right top element is positioned at left:1000px and its width is 600px and
the width of the largest element in the content is 2100px.  So if the browser
window width (precisely documentElement clientWidth) is greater than 1100px, the
right top element is not suitable for scroll-snap-align:start, thus some test
cases fail.
@hiikezoe
Copy link
Contributor Author

@bokand would you mind looking at this?

@bokand
Copy link
Contributor

bokand commented Feb 19, 2019

LGTM but I don't think I'm a reviewer here.

+@sunyunjia as FYI

@tabatkins tabatkins merged commit 58a5e30 into web-platform-tests:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants