Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/teamspeak: ipv6 support #55440

Merged
merged 1 commit into from Feb 10, 2019
Merged

nixos/teamspeak: ipv6 support #55440

merged 1 commit into from Feb 10, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 8, 2019 •
edited

Unlike the options descriptions the service was not listen to any
IPs because the address family was limited to ipv4.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
teamspeak: ipv6 support
6c28dd8 
Unlike the options descriptions the service was not listen to any
IPs because the address family was limited to ipv4.
@Mic92 Mic92 requested a review from infinisil as a code owner February 8, 2019 10:30
@Mic92 Mic92 changed the title teamspeak: ipv6 support nixos/teamspeak: ipv6 support Feb 8, 2019
@Mic92 Mic92 merged commit 393b151 into NixOS:master Feb 10, 2019
@Gerschtli
Copy link
Contributor

Does this really work? Because Teamspeak Server does not support IPv6 at the moment, AFAIK

@Mic92 Mic92 deleted the teamspeak branch March 7, 2019 18:18
@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2019

@Gerschtli good question. I can only confirm that my monitoring system no longer complains because the port is open externally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @Gerschtli @GrahamcOfBorg