Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waf: 2.0.13 -> 2.0.14 #55469

Merged
merged 1 commit into from Feb 24, 2019
Merged

waf: 2.0.13 -> 2.0.14 #55469

merged 1 commit into from Feb 24, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 9, 2019

Motivation for this change

Bumping to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Feb 9, 2019

CC @vrthra

@bhipple
Copy link
Contributor Author

bhipple commented Feb 10, 2019

Sorry for spamming everyone; I rebased from master to staging after seeing the number of rebuilds, and github seems to have added quite a few reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants