pythonPackages.requests: update base16 hash to more conventional base32 hash #55468
Conversation
…32 hash nix-hash --type sha256 --to-base32 ea881... converts to this shorter hash, which is what is printed on prefetch-url validations as well. This does not cause a package rebuild or hash change.
|
We usually prefer base16 for Python packages because these can easily be compared against those published on PyPI. |
|
It will be nice to have a wide agreement on this. It's not rare for me to solve conflicts between these two styles (master and staging*). |
|
That will mostly be resolved once nix-community/nixpkgs-update#106 is fixed. |
|
As discussed nix-community/nixpkgs-update#106 (comment) and in the previous comment, @FRidh and I are in favor of just using base32 exclusively for simplicity and consistency with the rest of nixpkgs (and for consistency with non-pypi python packages), in which case this PR can be merged and we should update the python manual guidelines. That said, I doubt either of us feels that strongly about it; any objections @dotlambda? |
|
I don't have any objections but feel like this is simply not worth the hassle. Why make a change if the current situation works perfectly fine? It might even break peoples' patches. What we can agree upon is to use base32 hashes in the future. |
| @@ -20,7 +20,7 @@ buildPythonPackage rec { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| description = "An authentication handler for using Kerberos with Python Requests."; | |||
| homepage = "https://github.com/requests/requests-kerberos"; | |||
| homepage = https://github.com/requests/requests-kerberos; | |||
There was a problem hiding this comment.
url are their own type and they're unquoted
| @@ -8,7 +8,7 @@ buildPythonPackage rec { | |||
|
|
|||
| src = fetchPypi { | |||
There was a problem hiding this comment.
requests is updated in staging-next, so there's no point doing this.
nix-hash --type sha256 --to-base32 ea881... converts to this shorter hash, which
is what is printed on prefetch-url validations as well. This does not cause a
package rebuild or hash change.
Motivation for this change
Just doing some standardization and cleanup. Also removed unnecessary quotes on a homepage url.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)