Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyslurm: remove version check #55455

Closed
wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 8, 2019

Motivation for this change

pythonPackages.pyslurm has a check for the version of slurm to see if they are compatible. This prevents maintainers from bumping slurm.

If we look at a typical upstream version bump, it looks like:
PySlurm/pyslurm@9477102
Nothing is changed other than the hardcoded max version. So, I think, we should take a more optimistic approach and make the check non-fatal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @markuskowa as slurm maintainer
cc @giovtorres as pyslurm upstream
this unblocks #55145

@bhipple
Copy link
Contributor

bhipple commented Feb 9, 2019

I agree this check is a pain and often useless, but why not just bump slurm and pyslurm atomically in PRs, as upstream intends? NixPkgs is ideally suited to be able to do this without too much hassle.

@markuskowa
Copy link
Member

I agree that the version check might be a bit too strict for patch-level updates but removing it maybe won't help for major version jumps of slurm.
By removing the check we also bypass the QA of pyslurm.
I am not convinced that just removing it is the best solution.

Maybe @giovtorres can give some more insight, why pyslurm uses this version check the way it does?

I agree this check is a pain and often useless, but why not just bump slurm and pyslurm atomically in PRs, as upstream intends? NixPkgs is ideally suited to be able to do this without too much hassle.
You mean upgrading both packages at the same time?

@giovtorres
Copy link

This has been on my backlog for a while. I think it would be better to refactor the version check to instead check against MAJOR.MINOR version and ignore the check for the trailing .MICRO, which I concur has become unnecessary in the past couple Slurm releases. Would this help with your packaging?

@giovtorres
Copy link

See: PySlurm/pyslurm#137

@markuskowa
Copy link
Member

@giovtorres Not checking the micro versions would certainly help. Would that also work for the minor version?

@giovtorres
Copy link

giovtorres commented Feb 9, 2019

If I remember correctly, there's usually a small to fair amount of changes between releases, so much so that I think we would want to keep checking the minor version.

@markuskowa
Copy link
Member

@giovtorres thanks for the fix.

@veprbl we can take PySlurm/pyslurm@d3703f2 instead.

@veprbl
Copy link
Member Author

veprbl commented Feb 13, 2019

@markuskowa Done: #55677

@giovtorres Thank you. I hope this won't create inconvenience for you.

@veprbl veprbl closed this Feb 13, 2019
@veprbl veprbl deleted the pr/pyslurm_remove_version_check branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants