Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textadept: 9.3 -> 10.2 #55480

Merged
merged 1 commit into from Feb 10, 2019
Merged

textadept: 9.3 -> 10.2 #55480

merged 1 commit into from Feb 10, 2019

Conversation

brainrake
Copy link
Contributor

Motivation for this change

Package was out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Feb 10, 2019
View reviewed changes
pkgs/applications/editors/textadept/deps.nix
@@ -0,0 +1,42 @@
{
"542782a4df7d.zip" = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file automatically generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but i put it in a format where it could easily be

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would have committed the script if there was one ofc

@7c6f434c 7c6f434c merged commit 3e81432 into NixOS:master Feb 10, 2019
@7c6f434c
Copy link
Member

Mention me if you want to do a PR sharing the deps.nix generator somewhere near the package (in case it was an external script)

@brainrake
Copy link
Contributor Author

There's no script, I just like to imagine I am one. And now it's easier to write, and more probable that someone will.
Unfortunately the source for the data is a makefile with some ad-hoc stuff, and one of the urls points to a hg tip (like a git branch, content may change). I used the latest revision at the time of packaging, seems to work.

@7c6f434c
Copy link
Member

Sure, and the list is also convenient to use.

@brainrake brainrake deleted the update-textadept branch February 11, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brainrake @7c6f434c @Mic92 @GrahamcOfBorg