Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.22.5 -> 2.22.6 #55481

Merged
merged 1 commit into from Feb 10, 2019
Merged

webkitgtk: 2.22.5 -> 2.22.6 #55481

merged 1 commit into from Feb 10, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Feb 9, 2019

Motivation for this change

changelog: https://webkitgtk.org/2019/02/09/webkitgtk2.22.6-released.html

security advisory: https://webkitgtk.org/security/WSA-2019-0001.html

Things done

Built and tested that epiphany works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built almost every dependent package fine 👍

(almost meaning I excluded building a few)

@hedning hedning merged commit eb4e9ba into NixOS:master Feb 10, 2019
@hedning hedning deleted the webkitgtk-2.22.6 branch October 15, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @worldofpeace @GrahamcOfBorg