Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a folder for radio-related applications #55483

Merged
merged 35 commits into from Feb 9, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Feb 9, 2019

Motivation for this change

Most of the relevant ham radio applications tend to end up in misc, but there's a quite wide range of applications out there and I intend to package more of them up since nixpkgs is quite lacking in that field. Sure we have some of the beasts (like gnuradio) but we're still missing out on lots of them.

So this is my initial attempt to just gather existing derivations in one place.

I'm pretty sure that there's no changed packages at all so I don't think there should be any rebuilds. But I will check this when the builder bot have done some work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Feb 9, 2019

Well, zero changed packages sounds good to me 😄

@markuskowa
Copy link
Member

Great idea, that move was long overdue. Would you mind also moving the following paths:

pkgs/applications/misc/limesuite
pkgs/applications/misc/welle-io
pkgs/applications/misc/soapy*
pkgs/applications/audio/minimodem
pkgs/applications/misc/gnss-sdr
pkgs/applications/misc/urh

@etu
Copy link
Contributor Author

etu commented Feb 9, 2019

@markuskowa Moved those and found a bunch more :-p

@markuskowa
Copy link
Member

Thanks! Found even some more:

pkgs/tools/misc/kalibrate-hackrf
pkgs/development/tools/misc/uhd

@etu etu force-pushed the create-applications-radio-directory branch from 3273afe to 45df33e Compare February 9, 2019 19:03
@etu
Copy link
Contributor Author

etu commented Feb 9, 2019

@GrahamcOfBorg eval

@etu etu force-pushed the create-applications-radio-directory branch 2 times, most recently from a6ac1f7 to a730231 Compare February 9, 2019 19:47
@etu
Copy link
Contributor Author

etu commented Feb 9, 2019

Fixed the breakage of eval

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

@markuskowa
Copy link
Member

Sorry for the merge conflict. :/

@etu etu force-pushed the create-applications-radio-directory branch from a730231 to 4619f2a Compare February 9, 2019 20:40
@etu
Copy link
Contributor Author

etu commented Feb 9, 2019

@markuskowa And rebase is done

@markuskowa markuskowa merged commit 77af55e into NixOS:master Feb 9, 2019
@etu etu deleted the create-applications-radio-directory branch February 9, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants