Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttrss: database.passwordFile, ldap plugin, configureable socket #55432

Merged
merged 3 commits into from Feb 10, 2019
Merged

ttrss: database.passwordFile, ldap plugin, configureable socket #55432

merged 3 commits into from Feb 10, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 8, 2019 •
edited

Motivation for this change

I use these changes for several months now on my server.
Time to get them upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from infinisil as a code owner February 8, 2019 07:10
@Mic92
Copy link
Member Author

Mic92 commented Feb 8, 2019

cc @dasJ

@Mic92 Mic92 merged commit d59f9c0 into NixOS:master Feb 10, 2019
@Mic92 Mic92 deleted the ttrss branch September 5, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg