[compositing] Computed value tests #15319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With Blink/Edge/Safari, |
|
@plinss please review |
|
@nikosandronikos please review |
|
@chrishtr Would you be happy to be added as a WPT reviewer for compositing? |
emilio
approved these changes
Jul 11, 2019
|
Sorry I spaced and missed this comment. I can review in the future, yes. |
background-blend-mode, isolation, mix-blend-mode computed values are as specified. https://drafts.fxtf.org/compositing-1/#property-index All tests pass with Firefox. Three background-blend-mode tests fail with Blink/Edge/Safari: expected "normal, luminosity" but got "normal" expected "screen, overlay" but got "screen" expected "color, saturation" but got "color"
ewilligers
force-pushed
the
compositing-computed
branch
from
4d9cd0b
to
fae5d5d
Compare
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
background-blend-mode, isolation, mix-blend-mode computed values are as specified. https://drafts.fxtf.org/compositing-1/#property-index All tests pass with Firefox. Three background-blend-mode tests fail with Blink/Edge/Safari: expected "normal, luminosity" but got "normal" expected "screen, overlay" but got "screen" expected "color, saturation" but got "color"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background-blend-mode, isolation, mix-blend-mode computed values are as specified.
https://drafts.fxtf.org/compositing-1/#property-index
All tests pass with Firefox.
Three background-blend-mode tests fail with Blink/Edge/Safari:
expected "normal, luminosity" but got "normal"
expected "screen, overlay" but got "screen"
expected "color, saturation" but got "color"