Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asyncssh: 1.14.0 -> 1.15.1 #55417

Closed
wants to merge 1 commit into from
Closed

pythonPackages.asyncssh: 1.14.0 -> 1.15.1 #55417

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

The usual.

Changelog: https://github.com/ronf/asyncssh/blob/master/docs/changes.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.asyncssh

@worldofpeace
Copy link
Contributor Author

Hmm, lots of errors like

======================================================================
ERROR: setUpClass (tests.test_x11._TestX11)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-python3.7-asyncssh-1.15.1.drv-0/asyncssh-1.15.1/tests/test_x11.py", line 280, in setUpClass
    super().setUpClass()
  File "/private/tmp/nix-build-python3.7-asyncssh-1.15.1.drv-0/asyncssh-1.15.1/tests/util.py", line 345, in setUpClass
    super().setUpClass()
  File "/private/tmp/nix-build-python3.7-asyncssh-1.15.1.drv-0/asyncssh-1.15.1/tests/util.py", line 325, in setUpClass
    cls._tempdir = tempfile.TemporaryDirectory()
  File "/nix/store/3cgv8dk5hp37b15v581w42dwd7cg0cmn-python3-3.7.2/lib/python3.7/tempfile.py", line 788, in __init__
    self.name = mkdtemp(suffix, prefix, dir)
  File "/nix/store/3cgv8dk5hp37b15v581w42dwd7cg0cmn-python3-3.7.2/lib/python3.7/tempfile.py", line 366, in mkdtemp
    _os.mkdir(file, 0o700)
FileNotFoundError: [Errno 2] No such file or directory: 'xxx/tmpor2i4j6z'
----------------------------------------------------------------------

Any ideas @Ma27? (deferring to you because you're helpful)

@Ma27
Copy link
Member

Ma27 commented Feb 8, 2019

Hmm I'm a bit confused: I didn't get any FileNotFoundError and most of the tests break with the following errors:

======================================================================
ERROR: test_attach_lock_failure (tests.test_x11._TestX11)
Test X11 listener attach when Xauthority can't be locked
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2/lib/python3.7/unittest/mock.py", line 1195, in patched
    return func(*args, **keywargs)
  File "/build/asyncssh-1.15.1/tests/util.py", line 77, in async_wrapper
    return self.loop.run_until_complete(wrapped_func)
  File "/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/build/asyncssh-1.15.1/tests/test_x11.py", line 623, in test_attach_lock_failure
    yield from self._check_x11('connect l', exc=asyncssh.ChannelOpenError)
  File "/build/asyncssh-1.15.1/tests/test_x11.py", line 340, in _check_x11
    with (yield from self.connect()) as conn:
  File "/build/asyncssh-1.15.1/asyncssh/misc.py", line 179, in __iter__
    return (yield from self._coro)
  File "/build/asyncssh-1.15.1/tests/server.py", line 305, in connect
    conn, _ = yield from self.create_connection(None, **kwargs)
  File "/build/asyncssh-1.15.1/tests/server.py", line 299, in create_connection
    **kwargs))
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 5110, in create_connection
    yield from auth_waiter
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 627, in data_received
    while self._inpbuf and self._recv_handler():
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 847, in _recv_packet
    processed = handler.process_packet(pkttype, seq, packet)
  File "/build/asyncssh-1.15.1/asyncssh/packet.py", line 215, in process_packet
    self._packet_handlers[pkttype](self, pkttype, pktid, packet)
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 1414, in _process_kexinit
    self._kex = get_kex(self, kex_alg)
  File "/build/asyncssh-1.15.1/asyncssh/kex.py", line 122, in get_kex
    return handler(alg, conn, hash_alg, *args)
  File "/build/asyncssh-1.15.1/asyncssh/kex_ecdh.py", line 47, in __init__
    self._priv = ecdh_class(*args)
  File "/build/asyncssh-1.15.1/asyncssh/crypto/curve25519.py", line 31, in __init__
    self._priv_key = x25519.X25519PrivateKey.generate()
  File "/nix/store/zp061rvpg2faa81k1rnflxmm1d1li4zi-python3.7-cryptography-2.3.1/lib/python3.7/site-packages/cryptography/hazmat/primitives/asymmetric/x25519.py", line 39, in generate
    _Reasons.UNSUPPORTED_EXCHANGE_ALGORITHM
cryptography.exceptions.UnsupportedAlgorithm: X25519 is not supported by this version of OpenSSL.

Built with Nix 2.1.3 and sandboxing enabled.

@worldofpeace
Copy link
Contributor Author

Hmm I'm a bit confused: I didn't get any FileNotFoundError and most of the tests break with the following errors:

======================================================================
ERROR: test_attach_lock_failure (tests.test_x11._TestX11)
Test X11 listener attach when Xauthority can't be locked
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2/lib/python3.7/unittest/mock.py", line 1195, in patched
    return func(*args, **keywargs)
  File "/build/asyncssh-1.15.1/tests/util.py", line 77, in async_wrapper
    return self.loop.run_until_complete(wrapped_func)
  File "/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/build/asyncssh-1.15.1/tests/test_x11.py", line 623, in test_attach_lock_failure
    yield from self._check_x11('connect l', exc=asyncssh.ChannelOpenError)
  File "/build/asyncssh-1.15.1/tests/test_x11.py", line 340, in _check_x11
    with (yield from self.connect()) as conn:
  File "/build/asyncssh-1.15.1/asyncssh/misc.py", line 179, in __iter__
    return (yield from self._coro)
  File "/build/asyncssh-1.15.1/tests/server.py", line 305, in connect
    conn, _ = yield from self.create_connection(None, **kwargs)
  File "/build/asyncssh-1.15.1/tests/server.py", line 299, in create_connection
    **kwargs))
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 5110, in create_connection
    yield from auth_waiter
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 627, in data_received
    while self._inpbuf and self._recv_handler():
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 847, in _recv_packet
    processed = handler.process_packet(pkttype, seq, packet)
  File "/build/asyncssh-1.15.1/asyncssh/packet.py", line 215, in process_packet
    self._packet_handlers[pkttype](self, pkttype, pktid, packet)
  File "/build/asyncssh-1.15.1/asyncssh/connection.py", line 1414, in _process_kexinit
    self._kex = get_kex(self, kex_alg)
  File "/build/asyncssh-1.15.1/asyncssh/kex.py", line 122, in get_kex
    return handler(alg, conn, hash_alg, *args)
  File "/build/asyncssh-1.15.1/asyncssh/kex_ecdh.py", line 47, in __init__
    self._priv = ecdh_class(*args)
  File "/build/asyncssh-1.15.1/asyncssh/crypto/curve25519.py", line 31, in __init__
    self._priv_key = x25519.X25519PrivateKey.generate()
  File "/nix/store/zp061rvpg2faa81k1rnflxmm1d1li4zi-python3.7-cryptography-2.3.1/lib/python3.7/site-packages/cryptography/hazmat/primitives/asymmetric/x25519.py", line 39, in generate
    _Reasons.UNSUPPORTED_EXCHANGE_ALGORITHM
cryptography.exceptions.UnsupportedAlgorithm: X25519 is not supported by this version of OpenSSL.

Built with Nix 2.1.3 and sandboxing enabled.

Ahh I see those now, I was also seeing the file not found errors from ofborg's build logs, https://logs.nix.ci/?key=nixos/nixpkgs.55417&attempt_id=9c2849a4-67cf-418f-a629-5f84330d3829

Also see them when I run the tests locally.

As for the cryptography exceptions, I think I might find something in docs, or the changelog to investigate.

@worldofpeace
Copy link
Contributor Author

Looks like this got bumped anyway.

@worldofpeace worldofpeace deleted the asyncssh/1.15.1 branch March 22, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @Ma27 @ryantm @GrahamcOfBorg