[css-grid] Overflow should be computed with the actual logical bottom #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1459620
branch
2 times, most recently
from
0dcbd96
to
0b52ad4
Compare
In order to compute the 'auto' height of the grid container, we set temporarily a value based on the tracks' size. We can see this value as a kind of 'intrinsic height'. Then, we call to the UpdateLogicalHeight function to finally compute the grid container's actual logical height. In order to compute the overflow area in the grid container we should use the result of the ClientLogicalBottom function. However, we were retrieving this value just after setting the tracks-based temporary height, and before computing the actual logical height. The consequence of this wrong logic is that empty grid areas may affect the result of the ClientLogicalBottom and, as it's described in the bug, conclude that there is a content overflow in the grid container, even if such container has no grid items at all. Since the grid itself is not a box, it can't contribute to the grid container's content size; instead, its grid items should. This change ensures that we always use the actual grid container's logical bottom to properly compute the overflow area. Bug: 928885 Change-Id: I05f86fbce06a83c0dbc0d5389bf0416763f8588a Reviewed-on: https://chromium-review.googlesource.com/c/1459620 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630735}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1459620
branch
from
0b52ad4
to
7cf6aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to compute the 'auto' height of the grid container, we set
temporarily a value based on the tracks' size. We can see this value as
a kind of 'intrinsic height'. Then, we call to the UpdateLogicalHeight
function to finally compute the grid container's actual logical height.
In order to compute the overflow area in the grid container we should
use the result of the ClientLogicalBottom function. However, we were
retrieving this value just after setting the tracks-based temporary
height, and before computing the actual logical height.
The consequence of this wrong logic is that empty grid areas may
affect the result of the ClientLogicalBottom and, as it's described
in the bug, conclude that there is a content overflow in the grid
container, even if such container has no grid items at all.
Since the grid itself is not a box, it can't contribute to the grid
container's content size; instead, its grid items should.
This change ensures that we always use the actual grid container's
logical bottom to properly compute the overflow area.
Bug: 928885
Change-Id: I05f86fbce06a83c0dbc0d5389bf0416763f8588a
Reviewed-on: https://chromium-review.googlesource.com/c/1459620
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#630735}