Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkit: fix CVE-2019-6133 #55419

Merged
merged 1 commit into from Feb 8, 2019
Merged

polkit: fix CVE-2019-6133 #55419

merged 1 commit into from Feb 8, 2019

Conversation

worldofpeace
Copy link
Contributor

Jann Horn of Google found that Polkit doesn't properly check
if a process is already authenticated, which can lead to an
authentication reuse by a different user0. See also 1

Closes #55391

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
polkit: fix CVE-2019-6133
7da64c9 
Jann Horn of Google found that Polkit doesn't properly check
if a process is already authenticated, which can lead to an
authentication reuse by a different user[0]. See also [1]

Closes NixOS#55391

[0]: https://bugs.chromium.org/p/project-zero/issues/detail?id=1692
[1]: https://gitlab.freedesktop.org/polkit/polkit/issues/75
@worldofpeace worldofpeace changed the base branch from master to staging February 7, 2019 23:08
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 7, 2019
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg eval

@Mic92 Mic92 merged commit 31188d7 into NixOS:staging Feb 8, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 8, 2019

also pushed to staging-18.09: a859ce5

@worldofpeace worldofpeace deleted the polkit-CVE-2019-6133 branch February 8, 2019 19:25
@worldofpeace
Copy link
Contributor Author

Thanks @Mic92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: freedesktop 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @Mic92 @GrahamcOfBorg