Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.uri-bytestring: fix build #55474

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Feb 9, 2019

Motivation for this change

Fix build package haskellPackages.uri-bytestring
Used this commit Soostone/uri-bytestring@e5c5602
Fix issue #53067

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 9, 2019

cc @peti

@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 9, 2019

Thanks!

@Izorkin Izorkin deleted the uri-bytestring-fix-build branch February 9, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants